forked from tensorflow/models
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh R-CNN Voxel Head #11
Open
zghera
wants to merge
11
commits into
mesh_rcnn
Choose a base branch
from
mesh_rcnn_voxel_head
base: mesh_rcnn
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am nearly complete with my initial rough implementation of the voxel head. The only thing I have left is the weight and bias initializations in build(). After that, I will start testing following yolo_head_test as an exemplar.
Added support to handle both ShapeNet and Pix3D as well as initialization of layer weight and biases.
See updated questions in voxel_head.py. Mypy is also failing to find the voxel_head module right now and I cannot figure out why. I will try to look into this after finishing up testing.
3 tasks
Since these boolean's will be set at the initialization of the model, it would be cheaper to do this evaluation at graph construction (with 'if-else') time as opposed to at runtime (with 'tf.cond').
Tyan3001
pushed a commit
that referenced
this pull request
Nov 30, 2021
* added shell scipt to prepare dataset * fixed path errors * added 1x and 3x experiment configs * fixed formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the voxel prediction head of the voxel branch for the re-implementation of Mesh RCNN in TensorFlow.
Type of change
Closes #5
Tests
Testing is captured in
voxel_head_test.py
. The unit tests include:test_network_creation
: Verify the output shapes of the voxel head.test_serialize_deserialize
: Create a network object that sets all of its config options.test_gradient_pass_though
: Ensure the gradients of the layer are not None.test_build_from_config
: Test head creation from config and factory function.Checklist
|--> Only warnings are from mypy that it cannot find library stubs/implementation for various modules.