Convert volume module to REST 2 and add fleet support #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdodsley
force-pushed
the
vol_v2
branch
2 times, most recently
from
28076df to
28447eb
Compare
sdodsley
force-pushed
the
vol_v2
branch
6 times, most recently
from
22cace9 to
8d2deea
Compare
sdodsley
force-pushed
the
vol_v2
branch
2 times, most recently
from
323d000 to
e329e02
Compare
sdodsley
force-pushed
the
vol_v2
branch
3 times, most recently
from
ab49a32 to
1f6d2dd
Compare
sdodsley
force-pushed
the
vol_v2
branch
2 times, most recently
from
eca7479 to
2436aed
Compare
plugins/modules/purefa_volume.py
Outdated
| else: | ||
| res = arrayv6.post_volumes( | ||
| res = array.post_volumes( |
There was a problem hiding this comment.
Still we need IF block here - if LooseVersion(CONTEXT_API_VERSION) <= LooseVersion(api_version)
Outer loop is DEFAULT_API_VERSION, this else loop is nested one, without this cloning for fleet array with context is not working.
skeerthivasan
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Convert volume module to use REST v2 and add support for fleets by using the new
contextparameter.ISSUE TYPE
COMPONENT NAME
purefa_volume.py