Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert vgroups to RESTv2 and add Fusion support #696

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Convert vgroups to RESTv2 and add Fusion support #696

merged 2 commits into from
Jan 29, 2025

Conversation

sdodsley
Copy link
Member

SUMMARY

Convert VG module to REST v2 and add context_names for Fusion support.

ISSUE TYPE
  • Feature Pull Request
  • REST 2 Pull Request
COMPONENT NAME

purefa_vg.py

@sdodsley sdodsley added enhancement New feature or request REST v2 labels Jan 17, 2025
@sdodsley sdodsley marked this pull request as ready for review January 17, 2025 22:15
@sdodsley sdodsley self-assigned this Jan 20, 2025
skeerthivasan
skeerthivasan reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@skeerthivasan skeerthivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we address these two minor issues, we are good to merge

plugins/modules/purefa_vg.py Outdated Show resolved Hide resolved
plugins/modules/purefa_vg.py Outdated Show resolved Hide resolved
skeerthivasan
skeerthivasan approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@skeerthivasan skeerthivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine now, good to merge

@sdodsley sdodsley merged commit 797312f into Pure-Storage-Ansible:master Jan 29, 2025
14 checks passed
@sdodsley sdodsley deleted the vg_v2 branch January 29, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeerthivasan skeerthivasan skeerthivasan approved these changes

Assignees

@sdodsley sdodsley

Labels
enhancement New feature or request REST v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdodsley @skeerthivasan