Skip to content

Add Fusion support to snapshot module #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

sdodsley
Copy link
Member

SUMMARY

Add Fusion support with context parameter.
Complete REST v2 conversion

ISSUE TYPE
  • Feature Pull Request
  • REST 2 Pull Request
COMPONENT NAME

purefa_snap.py

@sdodsley sdodsley added enhancement New feature or request REST v2 labels Jan 20, 2025
@sdodsley sdodsley self-assigned this Jan 20, 2025
@sdodsley sdodsley marked this pull request as ready for review January 20, 2025 22:05
res = array.post_remote_volume_snapshots(
source_names=[module.params["name"]],
on=module.params["offload"],
remote_volume_snapshot=RemoteVolumeSnapshotPost(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting unknown keyword error, remote_volume_snapshot not required here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote_volume_snapshot is a required field. I'll check what is going on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct syntax, I just tried it manually, and remote_volume_snapshot is required.
If this errors again can you send the full traceback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdodsley , might be backward compatibility issue, when we ran in purity version - 6.3.4, it errors out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeerthivasan I think I figured it out. Please retry

- Name of fleet member on which to perform the volume operation.
- This requires the array receiving the request is a member of a fleet
and the context name to be a member of the same fleet.
type: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add default="" for handling fleet array without context

@@ -562,6 +780,7 @@ def main():
default="present",
choices=["absent", "copy", "present", "rename"],
),
context=dict(type="str"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add default="" for handling fleet array without context

Copy link
Contributor

@skeerthivasan skeerthivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, validation done.

@sdodsley sdodsley merged commit 2e7e2ed into Pure-Storage-Ansible:master Feb 17, 2025
14 checks passed
@sdodsley sdodsley deleted the snap_v2 branch February 17, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request REST v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants