-
Notifications
You must be signed in to change notification settings - Fork 27
Add Fusion support to snapshot module #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plugins/modules/purefa_snap.py
Outdated
res = array.post_remote_volume_snapshots( | ||
source_names=[module.params["name"]], | ||
on=module.params["offload"], | ||
remote_volume_snapshot=RemoteVolumeSnapshotPost( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting unknown keyword error, remote_volume_snapshot not required here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remote_volume_snapshot
is a required field. I'll check what is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct syntax, I just tried it manually, and remote_volume_snapshot
is required.
If this errors again can you send the full traceback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdodsley , might be backward compatibility issue, when we ran in purity version - 6.3.4, it errors out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skeerthivasan I think I figured it out. Please retry
- Name of fleet member on which to perform the volume operation. | ||
- This requires the array receiving the request is a member of a fleet | ||
and the context name to be a member of the same fleet. | ||
type: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add default="" for handling fleet array without context
plugins/modules/purefa_snap.py
Outdated
@@ -562,6 +780,7 @@ def main(): | |||
default="present", | |||
choices=["absent", "copy", "present", "rename"], | |||
), | |||
context=dict(type="str"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add default="" for handling fleet array without context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge, validation done.
SUMMARY
Add Fusion support with
context
parameter.Complete REST v2 conversion
ISSUE TYPE
COMPONENT NAME
purefa_snap.py