Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fusion support to snapshot module #702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdodsley
Copy link
Member

SUMMARY

Add Fusion support with context parameter.
Complete REST v2 conversion

ISSUE TYPE
  • Feature Pull Request
  • REST 2 Pull Request
COMPONENT NAME

purefa_snap.py

@sdodsley sdodsley added enhancement New feature or request REST v2 labels Jan 20, 2025
@sdodsley sdodsley self-assigned this Jan 20, 2025
@sdodsley sdodsley marked this pull request as ready for review January 20, 2025 22:05
res = array.post_remote_volume_snapshots(
source_names=[module.params["name"]],
on=module.params["offload"],
remote_volume_snapshot=RemoteVolumeSnapshotPost(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting unknown keyword error, remote_volume_snapshot not required here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote_volume_snapshot is a required field. I'll check what is going on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct syntax, I just tried it manually, and remote_volume_snapshot is required.
If this errors again can you send the full traceback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request REST v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants