-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed generics and var, out and more than three parameters #17
Open
jho1965us
wants to merge
13
commits into
Puresharper:master
Choose a base branch
from
jho1965us:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem when instance method or constructor has more than three parameters
…ain types Come in handy for generic as CNeptune has a bug generating code for them
MS tool chain has problem recocnicing a file with double BOM
This will be removed when my bug fixes for CNeptune is accepted and proper NuGetPackage is ready
(One of several bug fixes for generic types)
Avoid overwrite input files so we can do repeated debug runs
NConcern need som data to uniqly identify generic methods and methods in generic type
This version correctly handle generic, ref, out parameters and methods with more than three parameters, it is backward compatible with the latest Virtuoze/NConcern (Latest commit 719d506 on Jun 6, 2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problems with:
New feature:
It is backward compatible with the latest Virtuoze/NConcern (Latest commit 719d506 on Jun 6, 2017)
But to actual weave generic methods and methods in generic types a newer NConcern is needed too.
For the final preparation of a pull request for NConcern I need a working NuGet Package of this version of CNeptune. Unfortunately I will not be able to work on that until next week (alternatively you can take the currently latest jho1965us/NConcern commit a801994, and fix the nuget package reference there your self).
Test cases for changes in this commit is part of the work done on NConcern.