Feature/fix issue 1959 - Publish an official isort Docker image #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2428 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 39 39
Lines 3090 3090
Branches 680 680
=======================================
Hits 3065 3065
Misses 14 14
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
reviewed
Oct 11, 2025
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # Build a new Docker image and push it to the GitHub Container Registry |
Member
There was a problem hiding this comment.
Honestly, I have no clue what I'm looking at here. Is there perhaps a link you can share with some example of another project that has a similar setup?
|
|
||
| # Install uv | ||
| COPY --from=ghcr.io/astral-sh/uv:0.6.0 /uv /uvx /bin/ | ||
| RUN pip install --no-cache-dir uv |
Member
There was a problem hiding this comment.
Why not copy from ghcr.io? And can we take the version as defined in pyproject.toml?
| RUN touch /isort/README.md | ||
| COPY . /isort | ||
| RUN SETUPTOOLS_SCM_PRETEND_VERSION=0.0.0 uv sync --all-extras --frozen | ||
| RUN SETUPTOOLS_SCM_PRETEND_VERSION=0.0.0 uv build . |
Member
There was a problem hiding this comment.
Shouldn't this be a different version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds steps to the existing release workflow, which package the isort Python distribution as a Docker image and push it to the GitHub container registry.
This fixes #1959.