feat!: remove old finders flag and legacy finder logic #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
- Coverage 99.25% 99.25% -0.01%
==========================================
Files 40 40
Lines 3094 3089 -5
Branches 681 680 -1
==========================================
- Hits 3071 3066 -5
Misses 13 13
Partials 10 10 🚀 New features to boost your workflow:
|
DanielNoord
reviewed
Nov 7, 2025
Member
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
Nice job! Just one comment
CHANGELOG.md
Outdated
|
|
||
| ### Unreleased | ||
|
|
||
| - Removed `--old-finders` flag and `old_finders` configuration option. The legacy finder logic that relied on environment introspection has been removed (#2445) @joao-faria-dev |
Member
There was a problem hiding this comment.
Can you also mention the magic-placement flag?
- Remove old-finders flag and config option - Remove related dependencies (pip_api and pipreqs) - Update tests and docs Closes PyCQA#2445
joao-faria-dev
force-pushed
the
remove-old-finders
branch
from
dab52a5 to
f7b5c18
Compare
DanielNoord
approved these changes
Nov 10, 2025
Member
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
Added a small commit to fix some linting issues, thanks for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey everyone, removing
--old-findersand, i believe, all related stuff!It's a breaking change, but i believe i covered pretty much everything. Please let me know if i forgot anything :)
Related issue
Closes #2445