Skip to content

Conversation

@joao-faria-dev
Copy link

@joao-faria-dev joao-faria-dev commented Nov 7, 2025

Description

After running the ./scripts/done.shit reveled a lot of code formatting that should be fixed (+1321, -486). Then analyzing the workflow i noticed that we are actually using ruff. So instead of add the lint changes and i'm just going to update the clean script to use ruff

Related issue

@joao-faria-dev joao-faria-dev force-pushed the chore/apply-code-formatting branch 2 times, most recently from 23c232e to 658c7af Compare November 7, 2025 02:43
@joao-faria-dev joao-faria-dev force-pushed the chore/apply-code-formatting branch from 658c7af to 9a63780 Compare November 7, 2025 02:43
@joao-faria-dev joao-faria-dev changed the title chore: fix code formmating on the codebase chore: replace black with ruff in clean.sh Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.25%. Comparing base (95f39d7) to head (9a63780).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          40       40           
  Lines        3094     3094           
  Branches      681      681           
=======================================
  Hits         3071     3071           
  Misses         13       13           
  Partials       10       10           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is kind of strange to me that the Lint job doesn't fail without this change. Is it possible that we also need to update that job so we also check everything in scripts for formatting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the clean script to use ruff instead of black

2 participants