-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dispersion docs #118
base: master
Are you sure you want to change the base?
Conversation
Yes, we also have to check the dispersion doc string and actual formula. There are definitely some errors in there (see also #55)
With deeper hierarchy you mean the hierarchy Dispersion -> IndexDispersion? I think it is very important to show the different behaviour and also explain why and that IndexDispersions cannot be added to other dispersions. For me I have the feeling that we should isolate the IndexDispersion as the special case and refer to the Dispersion as "normal" behaviour (which is also what we do in the code). Do you agree?
Just to understand clearly: You mean to splitting into group of dispersions, like empirical, physical etc. (of course we'd need to think what good categories would be)? |
If you include this distinction, which is as you say very important, you loose on a technical level the list of all dispersions in the sidebar. I liked the abilitiy to directly select the wanted dispersion. I just have not found the right setting inside sphinx to change that.
Maybe it is a problem on my side, but it takes a noticeable amount of time until all plotly graphics are loaded. |
Yes I agree that it would be nice to keep this list on the side.
Yes, it takes a while for me as well. Additionally, some of the graphs are randomly not displayed for me (the grid is, however, but the line is missing). Typically, reloading resolves this issue. Maybe there is also the possibility of caching the graphs as I think rn they are re-rendered on every page load (but I'm not sure how this is resolved). I think there we may also find a technical optimisation, but I find splitting the dispersions into sub-pages also a good idea 👍️. |
Just wanted to test PR builds at rtd |
Followup to #113
I think we should make the distinction between index and dielectric dispersions clearer.
Two problems: