Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Pytorch installation instructions in the documentation #188

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

MarJMue
Copy link
Collaborator

@MarJMue MarJMue commented Aug 19, 2024

No description provided.

@MarJMue MarJMue requested a review from domna August 22, 2024 08:57
Copy link
Member

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. This changes make sense. I'll also comment on the scipy thread and will see if they will revert the changes.

src/elli/solver4x4.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@domna
Copy link
Member

domna commented Sep 8, 2024

I would also leave #178 open as this is about scipy's expm being slow (which still is slow)

@domna
Copy link
Member

domna commented Sep 9, 2024

Looks all good. Feel free to merge when you are happy with this.

@MarJMue MarJMue merged commit a6e3bf0 into master Sep 9, 2024
12 checks passed
@MarJMue MarJMue deleted the update-expm-solver-documentation branch September 9, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants