add byonoy luminescence and absorbance plate readers #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwierenga
changed the title
rickwierenga
force-pushed
the
byonoy-luminescence
branch
from
1c31283 to
8f25dbf
Compare
rickwierenga
force-pushed
the
byonoy-luminescence
branch
from
300934e to
581d659
Compare
rickwierenga
force-pushed
the
main
branch
5 times, most recently
from
49a6770 to
159fd78
Compare
byonoy-dne
reviewed
Sep 16, 2025
rickwierenga
force-pushed
the
main
branch
2 times, most recently
from
bffeb24 to
a1d61b7
Compare
Member
Author
|
@BioCam could you please test? I have verified both to work on our machines |
rickwierenga
force-pushed
the
byonoy-luminescence
branch
from
3e0c1f8 to
125b7ff
Compare
rickwierenga
force-pushed
the
main
branch
2 times, most recently
from
1675cd6 to
2b2f7f9
Compare
Collaborator
|
Could you please confirm that this is the integration architecture? 
|
BioCam
reviewed
Nov 28, 2025
| size_y=85.59, # measured | ||
| size_z=14.07, # measured | ||
| child_location=Coordinate( | ||
| x=-(138 - 127.76) / 2, # measured |
Collaborator
There was a problem hiding this comment.
Where does the 138 mm come from?
| size_x=127.76, | ||
| size_y=85.59, | ||
| size_z=0, | ||
| child_location=Coordinate(x=(138 - 127.76) / 2, y=(95.7 - 85.59) / 2, z=27.7), |
Collaborator
There was a problem hiding this comment.
Is 27.7 mm the distance from the bottom of the "SBS Adapter" to the surface that the plate sits on?
I am getting:
- SBS_adapter.size_z = 17 mm
- detection_unit.size_z = 20 mm
- detection_unit.child_location.z = 16 mm
Collaborator
There was a problem hiding this comment.
i.e. I am getting the exact same dimensions for the dimensions which are specified in the manual:
Collaborator
|
Are measurements on this machine taken to 5 decimal places but the OEM's manual states the machine has a resolution to 3 decimal places? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absorbance will follow soon
todo: