-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #3
Merged
Merged
Maintenance #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able installs with maturin develop
It seems there is an issue with the CI setup (perhaps the generated matrix is wrong). I'll look into it |
mbway
force-pushed
the
maintenance
branch
10 times, most recently
from
March 24, 2024 20:01
4a8512f
to
f159ee4
Compare
mbway
added
CI-test-all
Test on every supported platform
CI-no-fail-fast
Do not stop testing at the first failure
labels
Mar 24, 2024
Merged
messense
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-no-fail-fast
Do not stop testing at the first failure
CI-test-all
Test on every supported platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates linters and raises the minimum maturin and python versions.
The minimum maturin version is now 1.5.0 where
maturin develop
first creates editable installs.Python 3.8 is still supported for another 7 months (source) but the import hook having a higher requirement than maturin isn't necessarily a problem (maturin itself has a higher requirement than pyo3). Raising the minimum to 3.9 simplifies some things.