Run uniffi-bindgen command instead of depending on uniffi_bindgen crates
#1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
… crate `uniffi_bindgen` crate is too heavy weight.
messense
force-pushed
the
uniffi-bindgen-cmd
branch
from
b570bdb
to
f9aef92
Compare
messense
force-pushed
the
uniffi-bindgen-cmd
branch
from
10b2fbf
to
7d19d79
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 13, 2022
1352: Run `uniffi-bindgen` command instead of depending on `uniffi_bindgen` crates r=messense a=messense `uniffi_bindgen` crate is too heavy weight and people uses `uniffi` usually have already installed uniffi-bindgen. Part of #1337, reduces `--no-default-features` compile time on M2 MacBook Air from 26.2s to 22.3s. Co-authored-by: messense <messense@icloud.com>
|
Build failed: |
messense
force-pushed
the
uniffi-bindgen-cmd
branch
from
e220e2f
to
65fc10d
Compare
messense
force-pushed
the
uniffi-bindgen-cmd
branch
from
65fc10d
to
a5ea984
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniffi_bindgencrate is too heavy weight and people usesuniffiusually have already installed uniffi-bindgen.Part of #1337, reduces
--no-default-featurescompile time on M2 MacBook Air from 26.2s to 22.3s.