Resolve clippy warnings from nightly (#4601)

pyo3-ffi/src/cpython/tupleobject.rs

@@ -12,10 +12,9 @@ pub struct PyTupleObject {
 // skipped _PyTuple_Resize
 // skipped _PyTuple_MaybeUntrack
 
-/// Macro, trading safety for speed
-
 // skipped _PyTuple_CAST
 
+/// Macro, trading safety for speed
 #[inline]
 #[cfg(not(PyPy))]
 pub unsafe fn PyTuple_GET_SIZE(op: *mut PyObject) -> Py_ssize_t {

pyo3-macros-backend/src/module.rs

@@ -559,7 +559,7 @@ fn find_and_remove_attribute(attrs: &mut Vec<syn::Attribute>, ident: &str) -> bo
     found
 }
 
-impl<'a> PartialEq<syn::Ident> for IdentOrStr<'a> {
+impl PartialEq<syn::Ident> for IdentOrStr<'_> {
     fn eq(&self, other: &syn::Ident) -> bool {
         match self {
             IdentOrStr::Str(s) => other == s,

pyo3-macros-backend/src/pyclass.rs

@@ -678,7 +678,7 @@ trait EnumVariant {
     }
 }
 
-impl<'a> EnumVariant for PyClassEnumVariant<'a> {
+impl EnumVariant for PyClassEnumVariant<'_> {
     fn get_ident(&self) -> &syn::Ident {
         match self {
             PyClassEnumVariant::Struct(struct_variant) => struct_variant.ident,
@@ -701,7 +701,7 @@ struct PyClassEnumUnitVariant<'a> {
     cfg_attrs: Vec<&'a syn::Attribute>,
 }
 
-impl<'a> EnumVariant for PyClassEnumUnitVariant<'a> {
+impl EnumVariant for PyClassEnumUnitVariant<'_> {
     fn get_ident(&self) -> &syn::Ident {
         self.ident
     }

src/buffer.rs

@@ -182,7 +182,7 @@ pub unsafe trait Element: Copy {
     fn is_compatible_format(format: &CStr) -> bool;
 }
 
-impl<'py, T: Element> FromPyObject<'py> for PyBuffer<T> {
+impl<T: Element> FromPyObject<'_> for PyBuffer<T> {
     fn extract_bound(obj: &Bound<'_, PyAny>) -> PyResult<PyBuffer<T>> {
         Self::get(obj)
     }

src/conversions/std/cell.rs

@@ -28,7 +28,7 @@ impl<'py, T: Copy + IntoPyObject<'py>> IntoPyObject<'py> for Cell<T> {
     }
 }
 
-impl<'a, 'py, T: Copy + IntoPyObject<'py>> IntoPyObject<'py> for &'a Cell<T> {
+impl<'py, T: Copy + IntoPyObject<'py>> IntoPyObject<'py> for &Cell<T> {
     type Target = T::Target;
     type Output = T::Output;
     type Error = T::Error;

src/conversions/std/num.rs

@@ -276,7 +276,7 @@ impl<'py> IntoPyObject<'py> for &'_ u8 {
     }
 }
 
-impl<'py> FromPyObject<'py> for u8 {
+impl FromPyObject<'_> for u8 {
     fn extract_bound(obj: &Bound<'_, PyAny>) -> PyResult<Self> {
         let val: c_long = extract_int!(obj, -1, ffi::PyLong_AsLong)?;
         u8::try_from(val).map_err(|e| exceptions::PyOverflowError::new_err(e.to_string()))

src/conversions/std/osstr.rs

@@ -199,7 +199,7 @@ impl<'py> IntoPyObject<'py> for OsString {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a OsString {
+impl IntoPy<PyObject> for &OsString {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()

src/conversions/std/path.rs

@@ -26,7 +26,7 @@ impl FromPyObject<'_> for PathBuf {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a Path {
+impl IntoPy<PyObject> for &Path {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()
@@ -55,14 +55,14 @@ impl<'py> IntoPyObject<'py> for &&Path {
     }
 }
 
-impl<'a> ToPyObject for Cow<'a, Path> {
+impl ToPyObject for Cow<'_, Path> {
     #[inline]
     fn to_object(&self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()
     }
 }
 
-impl<'a> IntoPy<PyObject> for Cow<'a, Path> {
+impl IntoPy<PyObject> for Cow<'_, Path> {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()
@@ -116,7 +116,7 @@ impl<'py> IntoPyObject<'py> for PathBuf {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a PathBuf {
+impl IntoPy<PyObject> for &PathBuf {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()

src/conversions/std/slice.rs

@@ -8,7 +8,7 @@ use crate::{
     Bound, IntoPy, Py, PyAny, PyErr, PyObject, PyResult, Python, ToPyObject,
 };
 
-impl<'a> IntoPy<PyObject> for &'a [u8] {
+impl IntoPy<PyObject> for &[u8] {
     fn into_py(self, py: Python<'_>) -> PyObject {
         PyBytes::new(py, self).unbind().into()
     }

src/conversions/std/string.rs

@@ -18,7 +18,7 @@ impl ToPyObject for str {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a str {
+impl IntoPy<PyObject> for &str {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()
@@ -30,7 +30,7 @@ impl<'a> IntoPy<PyObject> for &'a str {
     }
 }
 
-impl<'a> IntoPy<Py<PyString>> for &'a str {
+impl IntoPy<Py<PyString>> for &str {
     #[inline]
     fn into_py(self, py: Python<'_>) -> Py<PyString> {
         self.into_pyobject(py).unwrap().unbind()
@@ -179,7 +179,7 @@ impl<'py> IntoPyObject<'py> for String {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a String {
+impl IntoPy<PyObject> for &String {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()

src/err/mod.rs

@@ -891,7 +891,7 @@ impl ToPyObject for PyErr {
     }
 }
 
-impl<'a> IntoPy<PyObject> for &'a PyErr {
+impl IntoPy<PyObject> for &PyErr {
     #[inline]
     fn into_py(self, py: Python<'_>) -> PyObject {
         self.into_pyobject(py).unwrap().into_any().unbind()

src/impl_/pymethods.rs

@@ -300,7 +300,7 @@ where
     // ... and we cannot traverse a type which might be being mutated by a Rust thread
     && class_object.borrow_checker().try_borrow().is_ok() {
         struct TraverseGuard<'a, T: PyClass>(&'a PyClassObject<T>);
-        impl<'a, T: PyClass> Drop for TraverseGuard<'a,  T> {
+        impl<T: PyClass> Drop for TraverseGuard<'_,  T> {
             fn drop(&mut self) {
                 self.0.borrow_checker().release_borrow()
             }

src/instance.rs

@@ -43,9 +43,9 @@ mod bound_object_sealed {
     pub unsafe trait Sealed {}
 
     // SAFETY: `Bound` is layout-compatible with `*mut ffi::PyObject`.
-    unsafe impl<'py, T> Sealed for super::Bound<'py, T> {}
+    unsafe impl<T> Sealed for super::Bound<'_, T> {}
     // SAFETY: `Borrowed` is layout-compatible with `*mut ffi::PyObject`.
-    unsafe impl<'a, 'py, T> Sealed for super::Borrowed<'a, 'py, T> {}
+    unsafe impl<T> Sealed for super::Borrowed<'_, '_, T> {}
 }
 
 /// A GIL-attached equivalent to [`Py<T>`].
@@ -465,14 +465,14 @@ where
     }
 }
 
-impl<'py, T> std::fmt::Debug for Bound<'py, T> {
+impl<T> std::fmt::Debug for Bound<'_, T> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
         let any = self.as_any();
         python_format(any, any.repr(), f)
     }
 }
 
-impl<'py, T> std::fmt::Display for Bound<'py, T> {
+impl<T> std::fmt::Display for Bound<'_, T> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
         let any = self.as_any();
         python_format(any, any.str(), f)

src/pycell.rs

@@ -265,7 +265,7 @@ impl<'p, T: PyClass> PyRef<'p, T> {
     }
 }
 
-impl<'p, T, U> AsRef<U> for PyRef<'p, T>
+impl<T, U> AsRef<U> for PyRef<'_, T>
 where
     T: PyClass<BaseType = U>,
     U: PyClass,
@@ -429,7 +429,7 @@ where
     }
 }
 
-impl<'p, T: PyClass> Deref for PyRef<'p, T> {
+impl<T: PyClass> Deref for PyRef<'_, T> {
     type Target = T;
 
     #[inline]
@@ -438,7 +438,7 @@ impl<'p, T: PyClass> Deref for PyRef<'p, T> {
     }
 }
 
-impl<'p, T: PyClass> Drop for PyRef<'p, T> {
+impl<T: PyClass> Drop for PyRef<'_, T> {
     fn drop(&mut self) {
         self.inner
             .get_class_object()
@@ -479,7 +479,7 @@ impl<'a, 'py, T: PyClass> IntoPyObject<'py> for &'a PyRef<'py, T> {
     }
 }
 
-unsafe impl<'a, T: PyClass> AsPyPointer for PyRef<'a, T> {
+unsafe impl<T: PyClass> AsPyPointer for PyRef<'_, T> {
     fn as_ptr(&self) -> *mut ffi::PyObject {
         self.inner.as_ptr()
     }
@@ -508,7 +508,7 @@ impl<'p, T: PyClass<Frozen = False>> PyRefMut<'p, T> {
     }
 }
 
-impl<'p, T, U> AsRef<U> for PyRefMut<'p, T>
+impl<T, U> AsRef<U> for PyRefMut<'_, T>
 where
     T: PyClass<BaseType = U, Frozen = False>,
     U: PyClass<Frozen = False>,
@@ -518,7 +518,7 @@ where
     }
 }
 
-impl<'p, T, U> AsMut<U> for PyRefMut<'p, T>
+impl<T, U> AsMut<U> for PyRefMut<'_, T>
 where
     T: PyClass<BaseType = U, Frozen = False>,
     U: PyClass<Frozen = False>,
@@ -611,7 +611,7 @@ where
     }
 }
 
-impl<'p, T: PyClass<Frozen = False>> Deref for PyRefMut<'p, T> {
+impl<T: PyClass<Frozen = False>> Deref for PyRefMut<'_, T> {
     type Target = T;
 
     #[inline]
@@ -620,14 +620,14 @@ impl<'p, T: PyClass<Frozen = False>> Deref for PyRefMut<'p, T> {
     }
 }
 
-impl<'p, T: PyClass<Frozen = False>> DerefMut for PyRefMut<'p, T> {
+impl<T: PyClass<Frozen = False>> DerefMut for PyRefMut<'_, T> {
     #[inline]
     fn deref_mut(&mut self) -> &mut T {
         unsafe { &mut *self.inner.get_class_object().get_ptr() }
     }
 }
 
-impl<'p, T: PyClass<Frozen = False>> Drop for PyRefMut<'p, T> {
+impl<T: PyClass<Frozen = False>> Drop for PyRefMut<'_, T> {
     fn drop(&mut self) {
         self.inner
             .get_class_object()

src/pyclass/gc.rs

@@ -25,7 +25,7 @@ pub struct PyVisit<'a> {
     pub(crate) _guard: PhantomData<&'a ()>,
 }
 
-impl<'a> PyVisit<'a> {
+impl PyVisit<'_> {
     /// Visit `obj`.
     pub fn call<T>(&self, obj: &T) -> Result<(), PyTraverseError>
     where

src/types/dict.rs

@@ -466,7 +466,7 @@ impl<'py> Iterator for BoundDictIterator<'py> {
     }
 }
 
-impl<'py> ExactSizeIterator for BoundDictIterator<'py> {
+impl ExactSizeIterator for BoundDictIterator<'_> {
     fn len(&self) -> usize {
         self.len as usize
     }

src/types/frozenset.rs

@@ -242,7 +242,7 @@ impl<'py> Iterator for BoundFrozenSetIterator<'py> {
     }
 }
 
-impl<'py> ExactSizeIterator for BoundFrozenSetIterator<'py> {
+impl ExactSizeIterator for BoundFrozenSetIterator<'_> {
     fn len(&self) -> usize {
         self.remaining
     }

src/types/set.rs

@@ -279,7 +279,7 @@ impl<'py> Iterator for BoundSetIterator<'py> {
     }
 }
 
-impl<'py> ExactSizeIterator for BoundSetIterator<'py> {
+impl ExactSizeIterator for BoundSetIterator<'_> {
     fn len(&self) -> usize {
         self.remaining
     }

src/types/tuple.rs

@@ -383,7 +383,7 @@ impl<'py> Iterator for BoundTupleIterator<'py> {
     }
 }
 
-impl<'py> DoubleEndedIterator for BoundTupleIterator<'py> {
+impl DoubleEndedIterator for BoundTupleIterator<'_> {
     #[inline]
     fn next_back(&mut self) -> Option<Self::Item> {
         if self.index < self.length {
@@ -399,7 +399,7 @@ impl<'py> DoubleEndedIterator for BoundTupleIterator<'py> {
     }
 }
 
-impl<'py> ExactSizeIterator for BoundTupleIterator<'py> {
+impl ExactSizeIterator for BoundTupleIterator<'_> {
     fn len(&self) -> usize {
         self.length.saturating_sub(self.index)
     }
@@ -475,7 +475,7 @@ impl<'a, 'py> Iterator for BorrowedTupleIterator<'a, 'py> {
     }
 }
 
-impl<'a, 'py> DoubleEndedIterator for BorrowedTupleIterator<'a, 'py> {
+impl DoubleEndedIterator for BorrowedTupleIterator<'_, '_> {
     #[inline]
     fn next_back(&mut self) -> Option<Self::Item> {
         if self.index < self.length {
@@ -488,7 +488,7 @@ impl<'a, 'py> DoubleEndedIterator for BorrowedTupleIterator<'a, 'py> {
     }
 }
 
-impl<'a, 'py> ExactSizeIterator for BorrowedTupleIterator<'a, 'py> {
+impl ExactSizeIterator for BorrowedTupleIterator<'_, '_> {
     fn len(&self) -> usize {
         self.length.saturating_sub(self.index)
     }

tests/test_gc.rs

@@ -416,7 +416,7 @@ trait Traversable {
     fn __traverse__(&self, visit: PyVisit<'_>) -> Result<(), PyTraverseError>;
 }
 
-impl<'a> Traversable for PyRef<'a, HijackedTraverse> {
+impl Traversable for PyRef<'_, HijackedTraverse> {
     fn __traverse__(&self, _visit: PyVisit<'_>) -> Result<(), PyTraverseError> {
         self.hijacked.set(true);
         Ok(())