Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyMutex wrappers #4523

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add PyMutex wrappers #4523

wants to merge 15 commits into from

Commits on Sep 17, 2024

  1. define public pyo3_ffi::PyMutex::new()

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4865289 View commit details
    Browse the repository at this point in the history

  2. add pyo3::types::mutex for PyMutex wrappers

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    874d608 View commit details
    Browse the repository at this point in the history

  3. add changelog entry

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b1afb8b View commit details
    Browse the repository at this point in the history

  4. update rust API for PyMutex bindings following code review

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b3d193b View commit details
    Browse the repository at this point in the history

  5. make the test do something more interesting

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1229634 View commit details
    Browse the repository at this point in the history

  6. add Sync impl and make lock accept an immutable reference

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    307e8cf View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. respond to review comments

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f0ead33 View commit details
    Browse the repository at this point in the history

  2. add test for PyMutex blocking behavior

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4a0bf3b View commit details
    Browse the repository at this point in the history

  3. expand docstrings

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    17263cc View commit details
    Browse the repository at this point in the history

  4. fix clippy under abi3

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    37ffa3a View commit details
    Browse the repository at this point in the history

  5. simplify test

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    10f5faf View commit details
    Browse the repository at this point in the history

  6. use AtomicBool instead of OnceLock<bool>

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7df69a0 View commit details
    Browse the repository at this point in the history

  7. use std::hint::spin_loop() per clippy lint

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e35ea76 View commit details
    Browse the repository at this point in the history

  8. make PyMutex::new() const

    @ngoldbaum
    ngoldbaum committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    604b9bb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. fix docstring formatting

    @ngoldbaum
    ngoldbaum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    22ee351 View commit details
    Browse the repository at this point in the history