avoid calling PyType_GetSlot
on static types before Python 3.10
#4599
+279
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4563
I ran into a crash trying to merge that PR because I ended up calling
PyType_GetSlot
on a static type, which isn't legal before Python 3.10.This led to a problem... what to do about abi3 on Python 3.7 through 3.9, where we do occasionally need to look up slot in type objects, but the "good" way of using
PyType_GetSlot
may cause crashes. ThePyTypeObject
definition is also deliberately not available in the limited API.The only practical workaround I could think of is to inline the
PyTypeObject
definition (as of 3.9) into a helper function.get_slot(SLOT_NAME)
, which tries to do the right thing in each of the three cases:PyType_GetSlot