Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate inner, dot and einsum #421

Merged
merged 1 commit into from
Mar 31, 2024
Merged

deprecate inner, dot and einsum #421

merged 1 commit into from
Mar 31, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Mar 30, 2024

This migrates inner, dot and einsum to the Bound API.

adamreichold
adamreichold approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I think now we should go the last mile and add pyarray_bound! as well.

@adamreichold adamreichold merged commit 05b1b32 into PyO3:main Mar 31, 2024
33 of 35 checks passed
@Icxolu Icxolu deleted the sum-products branch March 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @adamreichold