[DRAFT] Provide 32-bit sizes/alignments for dtype::tests::test_dtype_methods_* #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicinmybrain
force-pushed
the
dtype-32bit
branch
from
0654661 to
3061de2
Compare
musicinmybrain
changed the title
Fixes test failures on 32-bit platforms.
musicinmybrain
force-pushed
the
dtype-32bit
branch
from
3061de2 to
d7728c2
Compare
|
Oops, this wasn’t quite ready. There were a few more values that needed to be adjusted. However, based on the CI, some of these alignments and offsets for 32-bit platforms apparently depend on the OS as well (Windows vs. the rest of the world). That’s getting to be a bit messy. |
|
I think it will be better for me to just suggest skipping these tests on ix86 in the Fedora package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test failures on 32-bit platforms.
The sizes and alignments are those observed when building a proposed
rust-numpypackage for Fedora on 32-bit x86.