Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function area and layout_from_area_density & allow auto chunks #328

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Oct 24, 2023

  • add functions area & layout_from_area_density
  • allow for auto chunks when loading cutout

Motivation and Context

The area function is helpful for custom workflows, the same with the new layout function.

The auto chunking can help to accelerate the computation of the conversion functions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up.
  • I have adjusted the docstrings in the code appropriately.
  • I have documented the effects of my code changes in the documentation doc/.
  • I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

 - add functions `area` & `layout_from_area_density`
 - allow for `auto` chunks when loading cutout
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a1f00f) 72.34% compared to head (d5d2316) 72.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   72.34%   72.49%   +0.14%     
==========================================
  Files          19       19              
  Lines        1696     1705       +9     
  Branches      294      296       +2     
==========================================
+ Hits         1227     1236       +9     
  Misses        387      387              
  Partials       82       82              
Files Coverage Δ
atlite/cutout.py 76.26% <100.00%> (+1.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

atlite/cutout.py Outdated Show resolved Hide resolved
atlite/cutout.py Outdated Show resolved Hide resolved
atlite/cutout.py Outdated Show resolved Hide resolved
atlite/cutout.py Show resolved Hide resolved
@FabianHofmann FabianHofmann merged commit 0110e18 into master Oct 24, 2023
5 checks passed
@FabianHofmann FabianHofmann deleted the allow-auto-chunks branch October 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants