-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.cumsum
for Variables and LinearExpression
#147
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 87.03% 86.95% -0.09%
==========================================
Files 14 14
Lines 3101 3112 +11
Branches 707 710 +3
==========================================
+ Hits 2699 2706 +7
- Misses 294 296 +2
- Partials 108 110 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks @hblunck. Just one small thing
and would you mind adding a small test to |
Co-authored-by: Fabian Hofmann <hofmann@fias.uni-frankfurt.de>
for more information, see https://pre-commit.ci
Hey @FabianHofmann , I added some tests, but they fail. On inspection (i.e. printing), the linear expressions are exactly what I would expect and they are also equal. But |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a good solution. Let's keep it simplistic then
Addresses #145
Implements (to the best of my knowledge)
.cumsum
methods forVariable
andLinearExpression
objects. No implementation is provided yet for e.g.LinearExpressionGroupBy
objects.