Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move mypy to gh raction and add more rules #344

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

lkstrp
Copy link
Member

@lkstrp lkstrp commented Aug 28, 2024

See PyPSA/PyPSA#1010

  • Use github action instead of pre-commit for checks
  • Add more rules

https://github.com/lkstrp/linopy/blob/325b3e2935cee6f384e5344257cc28d495f875db/pyproject.toml#L99-L110

To enable disallow_untyped_defs we need to make some more code changes. It currently throws 217 errors in the package. But I think most of them are **kwargs and missing none return type.

@FabianHofmann
Copy link
Collaborator

🚀

@lkstrp lkstrp merged commit 16f8bf1 into PyPSA:master Aug 28, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants