Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MindOpt floating release #429

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PeterKlein11
Copy link
Contributor

@PeterKlein11 PeterKlein11 commented Mar 19, 2025

Changes proposed in this Pull Request

MindOpt's floating license token fails to release unless m.dispose() is called. Adding this under the MindOpt class in solvers.py fixes the issue. However, I am not sure if this is best place to dispose of the model or if the returned m value gets used further.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [ x] I consent to the release of this PR's code under the MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant