Skip to content

Fix as_dataarray to apply coords parameter for DataArray input #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
FBumann wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix as_dataarray to apply coords parameter for DataArray input #551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
619b07c
Fix as_dataarray to apply coords parameter for DataArray input
FBumann Jan 20, 2026
44a94b5
1. Reindexes existing dims to match coord order
FBumann Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions linopy/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import operator
import os
from collections.abc import Callable, Generator, Hashable, Iterable, Sequence
from collections.abc import Callable, Generator, Hashable, Iterable, Mapping, Sequence
from functools import partial, reduce, wraps
from pathlib import Path
from typing import TYPE_CHECKING, Any, Generic, TypeVar, overload
Expand Down Expand Up @@ -264,7 +264,17 @@ def as_dataarray(
arr = DataArray(float(arr), coords=coords, dims=dims, **kwargs)
elif isinstance(arr, int | float | str | bool | list):
arr = DataArray(arr, coords=coords, dims=dims, **kwargs)

elif isinstance(arr, DataArray):
# Apply coords via reindex/expand if provided as dict (for consistency with other input types)
if coords is not None and isinstance(coords, Mapping):
# Reindex dimensions that exist in both arr and coords
reindex_coords = {k: v for k, v in coords.items() if k in arr.dims}
if reindex_coords:
arr = arr.reindex(reindex_coords)
# Expand to new dimensions from coords
expand_coords = {k: v for k, v in coords.items() if k not in arr.dims}
if expand_coords:
arr = arr.expand_dims(expand_coords)
elif not isinstance(arr, DataArray):
supported_types = [
np.number,
Expand Down