-
Notifications
You must be signed in to change notification settings - Fork 121
Rework Reservation API #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tazend
added a commit
that referenced
this pull request
Feb 2, 2025
* feat: rework reservations * add tests for reservations * fix docs * add custom enums for slurm * add u8_[set|parse]_bool_flag functions * add hack to improve generate docs for enum members (cherry picked from commit 8246fb2)
tazend
added a commit
that referenced
this pull request
Feb 2, 2025
* feat: rework reservations * add tests for reservations * fix docs * add custom enums for slurm * add u8_[set|parse]_bool_flag functions * add hack to improve generate docs for enum members (cherry picked from commit 8246fb2)
tazend
added a commit
that referenced
this pull request
Feb 2, 2025
* feat: rework reservations * add tests for reservations * fix docs * add custom enums for slurm * add u8_[set|parse]_bool_flag functions * add hack to improve generate docs for enum members * BACKPORT CHANGES: core_cnt and node_cnt were pointers in 23.2 and below (cherry picked from commit 8246fb2) (cherry picked from commit aa3cc42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267