Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nlpo3-python]: Add Bound to PyString and PyModule #83

Merged
merged 9 commits into from
Nov 11, 2024
Merged

[nlpo3-python]: Add Bound to PyString and PyModule #83

merged 9 commits into from
Nov 11, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 11, 2024 •
edited
Loading

  • Looks like in new version of Rust we need to put the Bound for generics, so the compiler can know what is implemented for that generic.
  • Add Bound to fix [nlpo3-python]: to_str not found in PyString  #80
    • For example, from text: &PyString to text: &Bound<'_, PyString>
  • Also rename DICT_COLLECTION to TOKENIZER_COLLECTION and revise docstring to make it more clear that the collection actually stores dictionary-based tokenizers (and not dictionaries).
  • Fix data path in Python unittest
  • Update package metadata
  • Update minimum supported version to 3.7 (PyO3's minimum supported version)
    • Except macOS arm64, the minimum supported version will be 3.8 as there's no macOS arm64 runner on GitHub to build and test

bact added 2 commits November 11, 2024 08:49
@bact
Add Bound to PyString and PyModule
fe46dfd 
Looks like in new version of Rust we need to put the Bound for generics, so the compiler can know what is implemented for that generic.

- Also rename DICT_COLLECTION to TOKENIZER_COLLECTION and revise docstring to make it more clear that the collection actually stores dictionary-based tokenizers (and not dictionaries).
- Update package metadata
@bact
Fix unittest data path
291cf8c
@bact bact added bug Something isn't working documentation Improvements or additions to documentation labels Nov 11, 2024
@bact
Copy link
Member Author

bact commented Nov 11, 2024

Pass all the python binding build and test, will merge.

@bact bact merged commit 8074526 into PyThaiNLP:main Nov 11, 2024
30 of 35 checks passed
@bact bact deleted the fix-to-str branch November 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nlpo3-python]: to_str not found in PyString
1 participant
@bact