BLD: pin cython language level to '2'

[tacaswell]

This is a simpler alternative to
#435

[tacaswell]

Given that the next version of cython is going to change the default, it may be worth doing a bug-fix release with this change?

[rgommers]

This change is cleaner than gh-434, but I'd say we should pin it to 3 not 2 in master (we're dropping 2.7 in the next release).

@tacaswell are the warnings bothering you somehow? It's not really a bug, just a build-time warning

[tacaswell]

I have a script the builds master branch of the whole stack. Without this patch pywt does not build against cython master.

[tacaswell]

To clarify, on cython master they now default to lanugage level "3str".

[rgommers]

Ah okay. We've already dropped 2.7 in master, so changing this to language_level: 3 is the way to go I think. And closing gh-434. @grlee77 agree?

[grlee77]

I agree adding language_level as done here is cleaner, but I think the various import syntax changes in gh-435 will still be necessary in order for this to work with language level 3. I can update gh-435 to just remove the language_level statements from the separate files and put it in setup.py instead as done here.

[rgommers]

sounds good to me

[rgommers]

Allright, merged gh-434 which has the language-level: 3 that came out of this PR. So closing this. Thanks @tacaswell

[tacaswell]

Great!

It may still be worth putting this change in a bug fix release.

[grlee77]

Yeah, that is a good idea. I made a PR of this commit vs. the 1.0.x branch in #454.