Guard against trying to transform along size 0 axes#506
Merged
rgommers merged 3 commits intoPyWavelets:masterfrom Jul 24, 2019
Merged
Guard against trying to transform along size 0 axes#506rgommers merged 3 commits intoPyWavelets:masterfrom
rgommers merged 3 commits intoPyWavelets:masterfrom
Conversation
make swt raise a ValueError for consistency with the dwt case
Member
|
LGTM, merged. Thanks @grlee77
incomplete sentence, want to edit that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cython function
dwt_axisdid not have a guard against zero-length inputs. This could result in PyWavelets getting stuck in an infinite loop as reported in #505 for datasets with more than 1 dimension where a transform along an axis with size zero was performed. The fix applied here applies to alldwtandwavedecfunctions. There was already a check like this in the case ofdwtandwavedecfor 1D data.The SWT functions did not suffer from the same infinite loop issue, but I have added similar checks there with the same error type for consistency with the DWT case.
closes #505