feat(loop): add optional overlap support to allow concurrent loop executions #2771

Lumabots · 2025-04-30T19:30:41Z

No description provided.

…xecutions Added a new overlap parameter to the loop decorator and Loop class to control whether loop iterations can run concurrently. When set to True, the next iteration will not wait for the previous one to finish, allowing overlapping executions—useful for long-running tasks that should not delay subsequent runs. Defaults to False to preserve current behavior. Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

…t: 'overlap' Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Exception in callback Future.set_result(True) handle: <TimerHandle when=203424.768941542 Future.set_result(True)> Traceback (most recent call last): File "/usr/local/lib/python3.11/asyncio/events.py", line 84, in _run self._context.run(self._callback, *self._args) asyncio.exceptions.InvalidStateError: invalid state Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-04-30T19:31:04Z

sorry i renamed the branch and it deleted the other one

plun1331

We should probably add an additional parameter for limiting the number of active tasks

CHANGELOG.md

discord/ext/tasks/__init__.py

Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-05-01T08:24:54Z

We should probably add an additional parameter for limiting the number of active tasks

maybe:
def init(self, ..., overlap: bool | int = True):

If overlap is:

True: allow overlapping tasks with no limit (default).

False: do not allow overlapping (wait for task to finish).

An int: allow overlapping up to n concurrent tasks.

add name for the tasks Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

discord/ext/tasks/__init__.py

Paillat-dev

lgtm, tested

… control

examples/background_task.py

…ng comments

examples/background_task.py

Lumabots and others added 10 commits April 18, 2025 16:44

style(pre-commit): auto fixes from pre-commit.com hooks

bfda3aa

Update CHANGELOG.md

8dc95c4

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

7dbf3a0

Update __init__.py

1f1ef8a

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

fix- TypeError: Loop.__init__() missing 1 required positional argumen…

570ae99

…t: 'overlap' Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

fix cancellation using overlap=true

c8f3bb4

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

fix identation

26a8ff1

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Merge branch 'master' into patch-2

253c67c

Lumabots requested a review from a team as a code owner April 30, 2025 19:30

pullapprove4 bot requested a review from Dorukyum April 30, 2025 19:30

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Apr 30, 2025

pullapprove4 bot requested a review from Lulalaby April 30, 2025 19:30

Lumabots changed the title ~~Overlap~~ feat(loop): add optional overlap support to allow concurrent loop executions Apr 30, 2025

plun1331 mentioned this pull request May 1, 2025

feat(loop): add optional overlap support to allow concurrent loop executions #2765

Closed

9 tasks

plun1331 previously requested changes May 1, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

discord/ext/tasks/__init__.py Outdated Show resolved Hide resolved

discord/ext/tasks/__init__.py Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels May 1, 2025

Lumabots and others added 2 commits May 1, 2025 11:17

Update CHANGELOG.md

7e4fd6a

Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update discord/ext/tasks/__init__.py

1562e64

Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots and others added 6 commits May 1, 2025 11:32

Update __init__.py

734ce8a

add name for the tasks Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

fc137dd

Update __init__.py

0898f82

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update __init__.py

209232f

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Update __init__.py

f24682a

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

style(pre-commit): auto fixes from pre-commit.com hooks

49bf2b7

pullapprove4 bot removed the PA: All Contributors pending label Sep 18, 2025

Paillat-dev requested changes Sep 19, 2025

View reviewed changes

discord/ext/tasks/__init__.py Outdated Show resolved Hide resolved

discord/ext/tasks/__init__.py Outdated Show resolved Hide resolved

discord/ext/tasks/__init__.py Outdated Show resolved Hide resolved

pullapprove4 bot removed the PA: Maintainers pending label Sep 19, 2025

paillat comment

4bb3a27

Lumabots dismissed Soheab’s stale review via 4bb3a27 September 19, 2025 08:37

Lumabots requested a review from Paillat-dev September 19, 2025 08:37

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Sep 19, 2025

Lumabots requested a review from Soheab September 19, 2025 08:37

This comment has been minimized.

Sign in to view

Paillat-dev previously approved these changes Sep 21, 2025

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Sep 21, 2025

This comment has been minimized.

Sign in to view

feat: add fetch_status_task to poll external service with concurrency…

38428fd

… control

Lumabots dismissed Paillat-dev’s stale review via 38428fd September 29, 2025 08:22

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Sep 29, 2025

Paillat-dev requested changes Sep 29, 2025

View reviewed changes

examples/background_task.py Outdated Show resolved Hide resolved

examples/background_task.py Outdated Show resolved Hide resolved

examples/background_task.py Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Sep 29, 2025

refactor: update fetch_status_task to improve logging and adjust timi…

c63dce0

…ng comments

Lumabots requested a review from Paillat-dev September 29, 2025 15:34

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Sep 29, 2025

Paillat-dev requested changes Sep 30, 2025

View reviewed changes

examples/background_task.py Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Sep 30, 2025

Soheab requested a review from a team October 3, 2025 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(loop): add optional overlap support to allow concurrent loop executions #2771

feat(loop): add optional overlap support to allow concurrent loop executions #2771

Uh oh!

Lumabots commented Apr 30, 2025 •

edited by Lulalaby

Loading

Uh oh!

Lumabots commented Apr 30, 2025

Uh oh!

plun1331 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented May 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Paillat-dev left a comment

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(loop): add optional overlap support to allow concurrent loop executions #2771

Are you sure you want to change the base?

feat(loop): add optional overlap support to allow concurrent loop executions #2771

Uh oh!

Conversation

Lumabots commented Apr 30, 2025 • edited by Lulalaby Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lumabots commented Apr 30, 2025

Uh oh!

plun1331 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Apr 30, 2025 •

edited by Lulalaby

Loading

Lumabots commented May 1, 2025 •

edited

Loading