Skip to content

Conversation

Lumabots
Copy link
Contributor

@Lumabots Lumabots commented May 3, 2025

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters). Implement better get_or_fetch #1856
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lumabots added 5 commits May 3, 2025 00:37
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

feat from #1856

Lumabots and others added 5 commits May 4, 2025 01:30
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

still not ready have some bug like : NameError: name 'VoiceChannel' is not defined
ig because of the type checking, i'll have to find a way to import it without circular import

@Paillat-dev
Copy link
Member

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

Well ig the issue come from the definition for the typevar, so will that resolve it ?

Lumabots and others added 8 commits May 4, 2025 18:22
… get_or_fetch shortcut

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author

Lumabots commented May 4, 2025

should be ready for review

@Lumabots
Copy link
Contributor Author

Lumabots commented May 4, 2025

just need to specify that this is breaking inside the changelog cos of modification of get_or_fetch and removal of get_or_fetch_user

@Soheab Soheab requested review from a team and removed request for Lulalaby October 3, 2025 16:18
@Soheab
Copy link
Contributor

Soheab commented Oct 10, 2025

Maybe an unintended side-effect, Guild + AppEmoji is valid:

emoji = await utils.get_or_fetch(<Guild>, discord.AppEmoji, <valid guild emoji id>)
print(type(emoji)) # discord.GuildEmoji

@Soheab
Copy link
Contributor

Soheab commented Oct 10, 2025

Tested and works, outside of the 2 comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants