Skip to content

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Aug 21, 2025

Summary

If you don't want your code to explode or something similar, don't use this PR, thanks. ;)

WIP.

A rewrite to its internals to fix various things.

I don't expect this to be merged on 2.7, so it should not block it

This is partially inspired on discord.py's voice code & imayhaveborkedit/voice-recv

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Related

Fixes #2833

@DA-344 DA-344 changed the title Voice internals rewrite to fix things fix(voice): Voice internals rewrite to fix things Aug 26, 2025
@DA-344
Copy link
Contributor Author

DA-344 commented Aug 30, 2025

This PR can now be tested, all features (and rewrite) should be done, and I need to fix errors.

There can be some breaking change, if you find one, let me know and i’ll add backwards compatibility.

@Paillat-dev
Copy link
Member

Mhm
image

@DA-344
Copy link
Contributor Author

DA-344 commented Aug 30, 2025

Yeah that is due to a type annotation i forgot to update but in my local machine it worked lol

@Lulalaby
Copy link
Member

@DA-344 just that u are aware: #2808

@DA-344 DA-344 force-pushed the feat/voice-rewrite-and-fixes branch from 741fd6e to fe8e602 Compare August 30, 2025 17:39
@Lulalaby Lulalaby force-pushed the master branch 2 times, most recently from b55c125 to 82659b2 Compare August 30, 2025 21:10
@Lulalaby Lulalaby removed the on hold label Aug 30, 2025
This was linked to issues Sep 11, 2025
@atmaranto atmaranto mentioned this pull request Sep 11, 2025
3 tasks
@DA-344 DA-344 force-pushed the feat/voice-rewrite-and-fixes branch from c461cbf to a324844 Compare September 12, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice Rewrite Bot can't connect to voice chat Opus Decode Errors
3 participants