Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures on Github #94

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Fix CI failures on Github #94

merged 12 commits into from
Dec 2, 2024

Conversation

mcdonc
Copy link
Member

@mcdonc mcdonc commented Dec 2, 2024

Issue to help diagnose and fix CI problems with specific arch/OS types/versions.

So far:

  • add 3.13 to checked ci
  • use macos-sonoma instead of macos-latest to test under macos (later releases seem to fail)
  • merge musicinmybrain's local frame proxy fix for 3.13

@mcdonc mcdonc marked this pull request as ready for review December 2, 2024 01:37
@mcdonc mcdonc merged commit d4ab706 into main Dec 2, 2024
36 checks passed
@mcdonc mcdonc deleted the fix-ci branch December 2, 2024 01:38
@stevepiercy
Copy link
Member

@mcdonc I don't know if you found this resource for available macOS images.

https://github.com/actions/runner-images?tab=readme-ov-file#available-images

Each item has a link to its README with Python and other system requirements.

Also the second example at the following link shows how to exclude a specific Python version from macos-latest and windows-latest, after first including them.

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#matrix-testing

@mcdonc
Copy link
Member Author

mcdonc commented Dec 2, 2024

@mcdonc I don't know if you found this resource for available macOS images.

https://github.com/actions/runner-images?tab=readme-ov-file#available-images

Each item has a link to its README with Python and other system requirements.

Also the second example at the following link shows how to exclude a specific Python version from macos-latest and windows-latest, after first including them.

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#matrix-testing

Thanks! I had seen the first link, but I think it's sufficient to test Venusian on an old MacOS version only on amd64 for now without complicating it across architectures. Maybe once MacOS is no longer supported on Intel we can change things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants