Skip to content

Conversation

sergey-gusev94
Copy link
Contributor

Fixes # None

Summary/Motivation:

Previously, the configuration did not account for the use of NLP and MINLP when Gurobi was selected as a subsolver within GAMS. This PR ensures that these problem types are properly recognized and supported.

Changes proposed in this PR:

  • Added support for NLP and MINLP when Gurobi is used as a subsolver within GAMS.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - and needed. Please:

@sergey-gusev94
Copy link
Contributor Author

I have reordered the set entries and added missing solvers.

@jsiirola
Copy link
Member

We should probably:

  • add a test that verifies that this data structure is correct
  • only create this data structure the first time it is needed (maybe move this to a class attribute?)

But, I am fine deferring these for a subsequent PR.

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (918824e) to head (d4f8a69).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3714      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files         896      896              
  Lines      103687   103687              
==========================================
+ Hits        92609    92621      +12     
+ Misses      11078    11066      -12     
Flag Coverage Δ
builders 29.10% <ø> (+<0.01%) ⬆️
default 85.93% <ø> (?)
expensive 35.86% <ø> (?)
linux 86.96% <ø> (-2.09%) ⬇️
linux_other 86.96% <ø> (ø)
osx 83.10% <ø> (ø)
win 85.23% <ø> (+0.01%) ⬆️
win_other 85.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsiirola jsiirola merged commit 7816915 into Pyomo:main Oct 1, 2025
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants