-
Notifications
You must be signed in to change notification settings - Fork 557
Gams gurobi valid solvers fix #3714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update the fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - and needed. Please:
- reorder the set entries to match the column order from https://www.gams.com/latest/docs/S_MAIN.html#SOLVERS_MODEL_TYPES
- verify the set matches those docs (I believe that RNLP is missing)
- [bonus] would you mind going through that table and verifying the other solvers, too (and add any missing entries)?
I have reordered the set entries and added missing solvers. |
We should probably:
But, I am fine deferring these for a subsequent PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 89.31% 89.32% +0.01%
==========================================
Files 896 896
Lines 103687 103687
==========================================
+ Hits 92609 92621 +12
+ Misses 11078 11066 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes # None
Summary/Motivation:
Previously, the configuration did not account for the use of NLP and MINLP when Gurobi was selected as a subsolver within GAMS. This PR ensures that these problem types are properly recognized and supported.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: