Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect after_routine warning #484

Merged

Conversation

bartmoorman
Copy link
Contributor

  • If the after_routine decorator is used after the before_routine decorator, the warning "twitchio.ext.routines The after_routine for <Routine[Routines.name]> has previously been set." is logged when it shouldn't be.
  • If the after_routine decorator is used twice for the same routine, no warning is logged.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@EvieePy EvieePy merged commit 4a59b7c into PythonistaGuild:main Feb 7, 2025
9 checks passed
@EvieePy
Copy link
Member

EvieePy commented Feb 7, 2025

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants