ADD Crashlytics #23
Merged
ADD Crashlytics #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Frank1234 do you still object to having a Firebase project and google-services.json in this template? |
Frank1234
requested changes
Sep 28, 2023
# Conflicts: # app/src/main/kotlin/nl/q42/template/MainApplication.kt # feature/home/src/main/kotlin/nl/q42/template/presentation/home/HomeViewModel.kt # gradle/libs.versions.toml
# Conflicts: # gradle/libs.versions.toml
ninovanhooff
added
ready for review
and removed
changes requested
sebaslogen
reviewed
Dec 15, 2023
core/navigation/src/main/kotlin/nl/q42/template/navigation/viewmodel/RouteNavigator.kt
Show resolved
Hide resolved
sebaslogen
requested changes
Dec 15, 2023
There was a problem hiding this comment.
I'm fine with adding Crashlytics by default but not with adding Analytics by default.
AFAIK, this is not GDPR complaint and that seems a dangerous think to forget when using a template.
Is it possible to leave analytics off by default, at least the parts that are non-GDPR compliant? And then add some doc on how to enable if you really need them.
because it might not be GDPR compliant This allows reverse proxies like Charles to inspect and manipulate traffic in development builds
sebaslogen
previously approved these changes
Dec 15, 2023
Frank1234
requested changes
Jan 29, 2024
app/src/main/kotlin/nl/q42/template/logging/CrashlyticsAntilog.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/nl/q42/template/logging/CrashlyticsAntilog.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/nl/q42/template/logging/CrashlyticsAntilog.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/nl/q42/template/logging/CrashlyticsAntilog.kt
Outdated
Show resolved
Hide resolved
crash-logging
# Conflicts: # gradle/libs.versions.toml
sebaslogen
previously approved these changes
Feb 23, 2024
crash-logging
sebaslogen
previously approved these changes
Mar 22, 2024
Techwolf12
previously approved these changes
Mar 22, 2024
# Conflicts: # feature/home/src/main/kotlin/nl/q42/template/presentation/home/HomeViewModel.kt
Frank1234
previously approved these changes
Mar 26, 2024
app/src/main/kotlin/nl/q42/template/logging/CrashlyticsLogger.kt
Outdated
Show resolved
Hide resolved
crash-logging
ninovanhooff
dismissed stale reviews from Frank1234, Techwolf12, and sebaslogen
via
191ba61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this important?
All projects probably use crashlytics