Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 2.0!! #62

Merged
merged 3 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: "corretto" # See 'Supported distributions' for available options
java-version: "17"
java-version: "21"
cache: "gradle"
- name: Update version code
uses: chkfung/android-version-actions@v1.2.1
Expand Down
4 changes: 2 additions & 2 deletions .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ plugins {
id "com.android.application"
alias libs.plugins.googleServices
alias libs.plugins.firebaseCrashlyticsPlugin
alias libs.plugins.compose.compiler
}

apply from: "$rootDir/build.module.feature-and-app.gradle"
Expand Down
6 changes: 3 additions & 3 deletions build.config.jvm.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ android {
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
sourceCompatibility JavaVersion.VERSION_21
targetCompatibility JavaVersion.VERSION_21
}
}
}
5 changes: 1 addition & 4 deletions build.dep.compose.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ android {
buildFeatures {
compose = true
}
composeOptions {
kotlinCompilerExtensionVersion = libs.versions.kotlinCompilerComposeExtensionVersion.get()
}
}

dependencies {
Expand All @@ -17,4 +14,4 @@ dependencies {
implementation(libs.composeUIToolingPreview)
implementation(libs.composeMaterial3)
implementation(libs.composeLifecycle)
}
}
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ plugins { // sets class paths only (because of 'apply false')
alias libs.plugins.ksp apply false
alias libs.plugins.googleServices apply false
alias libs.plugins.firebaseCrashlyticsPlugin apply false
alias libs.plugins.compose.compiler apply false
}

allprojects {
Expand Down
3 changes: 0 additions & 3 deletions build.module.feature-and-app.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ android {
buildFeatures {
compose = true
}
composeOptions {
kotlinCompilerExtensionVersion = libs.versions.kotlinCompilerComposeExtensionVersion.get()
}
packaging {
resources {
excludes += "/META-INF/{AL2.0,LGPL2.1}"
Expand Down
1 change: 1 addition & 0 deletions core/navigation/build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
id "com.android.library"
alias libs.plugins.compose.compiler
}
apply from: "$rootDir/build.module.library.gradle"
apply from: "$rootDir/build.dep.compose.gradle"
Expand Down
3 changes: 2 additions & 1 deletion core/ui/build.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
plugins {
id "com.android.library"
alias libs.plugins.compose.compiler
}
apply from: "$rootDir/build.module.library.gradle"
apply from: "$rootDir/build.dep.compose.gradle"

android {
namespace = "nl.q42.template.core.ui"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.components.SingletonComponent
import nl.q42.template.data.user.UserRepositoryImpl
import nl.q42.data.user.remote.model.UserApi
import nl.q42.template.data.user.remote.UserApi
import nl.q42.template.domain.user.repo.UserRepository
import retrofit2.Retrofit
import javax.inject.Singleton
Expand All @@ -29,4 +29,4 @@ internal interface UserRepoModule {
@Binds
@Singleton
fun bindUserRepository(impl: UserRepositoryImpl): UserRepository
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package nl.q42.data.user.remote.model
package nl.q42.template.data.user.remote

import com.haroldadmin.cnradapter.NetworkResponse
import nl.q42.template.actionresult.data.ApiErrorResponse
Expand All @@ -13,4 +13,4 @@ internal interface UserApi {
*/
@GET("get")
suspend fun getUsers(@Query("email") dummyEmailForResponse: String): NetworkResponse<UserDTO, ApiErrorResponse>
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package nl.q42.template.data.user.remote

import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import nl.q42.data.user.remote.model.UserApi
import nl.q42.template.actionresult.data.mapToActionResult
import nl.q42.template.actionresult.domain.ActionResult
import nl.q42.template.actionresult.domain.map
Expand Down
3 changes: 2 additions & 1 deletion feature/home/build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
id "com.android.library"
alias libs.plugins.compose.compiler
}
apply from: "$rootDir/build.module.feature-and-app.gradle"
apply from: "$rootDir/build.dep.navigation.gradle"
Expand All @@ -20,4 +21,4 @@ dependencies {
implementation project(':core:ui')
implementation project(':core:actionresult')
implementation project(':core:navigation')
}
}
3 changes: 2 additions & 1 deletion feature/onboarding/build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
id "com.android.library"
alias libs.plugins.compose.compiler
}
apply from: "$rootDir/build.module.feature-and-app.gradle"
apply from: "$rootDir/build.dep.navigation.gradle"
Expand All @@ -20,4 +21,4 @@ dependencies {
implementation project(':core:ui')
implementation project(':core:actionresult')
implementation project(':core:navigation')
}
}
32 changes: 16 additions & 16 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,30 +1,29 @@
[versions]
androidxCore = "1.12.0"
androidxLifecycle = "2.7.0"
kotlinxCoroutinesTest = "1.7.3"
androidxCore = "1.13.1"
androidxLifecycle = "2.8.1"
kotlinxCoroutinesTest = "1.8.1"
junit = "4.13.2"
mockkAndroid = "1.13.9"
jvmTarget = "17"
kotlin = "1.9.22"
ksp = "1.9.22-1.0.18"
gradlePlugin = "8.2.1"
googleServices = "4.4.0"
crashlyticsPlugin = "2.9.9"
firebaseBOM = "32.7.0"
jvmTarget = "21"
kotlin = "2.0.0"
ksp = "2.0.0-1.0.21"
gradlePlugin = "8.4.1"
googleServices = "4.4.1"
crashlyticsPlugin = "3.0.1"
firebaseBOM = "33.0.0"
manesVersions = "0.44.0"
littleRobotsCatalogUpdates = "0.8.1"
hilt = "2.50"
retrofit = "2.9.0"
retrofit = "2.10.0"
kotlinx-serialization = "1.6.3"
retrofit2KotlinxSerializationConverter = "1.0.0"
networkResponseAdapter = "5.0.0"
napier = "2.7.1"
composeDestinations = "1.9.60"
composeDestinations = "1.10.2"
okhttp = "4.12.0"
composePlatform = "2023.10.01"
kotlinCompilerComposeExtensionVersion = "1.5.8"
activityCompose = "1.8.2"
hiltNavigationCompose = "1.1.0"
composePlatform = "2024.05.00"
activityCompose = "1.9.0"
hiltNavigationCompose = "1.2.0"
composeLifecycle = "2.7.0"
turbine = "1.0.0"

Expand Down Expand Up @@ -71,3 +70,4 @@ hilt = { id = "com.google.dagger.hilt.android", version.ref = "hilt" }
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
googleServices = { id = "com.google.gms.google-services", version.ref = "googleServices" }
firebaseCrashlyticsPlugin = { id = "com.google.firebase.crashlytics", version.ref = "crashlyticsPlugin" }
compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Thu Jan 26 10:33:34 CET 2023
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading