Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom theming #77

Merged
merged 19 commits into from
Jan 24, 2025
Merged

Custom theming #77

merged 19 commits into from
Jan 24, 2025

Conversation

ninovanhooff
Copy link
Collaborator

@ninovanhooff ninovanhooff commented Sep 10, 2024 •
edited
Loading

Why is this important?

  • It was on the wishlist (in readme)
  • MaterialTheme is nice, but it cannot be reconciled with iOS. Therefore tokens in a shared design system are always necessary

Notes

  • Inspired by Hema
  • Removes dynamic color. Can probably be incorporated somewhere, but definetlely not 90% of projects use it
  • explicitly setting font style and color for all texts seems tedious, but in practice the boilerplate is reduced by creating core components like buttons etc (see TemplateButton())

@ninovanhooff
REMOVE theming from wishlist
ea6bb3d 
because that is what we are implementing here
@ninovanhooff
ADD custom theming
6c6ca7c 
Inspired by Hema implementation
@ninovanhooff
REMOVE dynamic color
43f2e23
@ninovanhooff ninovanhooff added the enhancement New feature or request label Sep 10, 2024
@ninovanhooff ninovanhooff requested a review from Vluuks September 10, 2024 12:08
izadiegizabal
izadiegizabal reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@izadiegizabal izadiegizabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice seeing some more theming added to the template app! i left a couple of comments 🪄

core/ui/src/main/kotlin/nl/q42/template/ui/theme/Theme.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/Theme.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/Theme.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/Dimens.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/AppColorTokens.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/compose/composables/widgets/TemplateButton.kt Outdated Show resolved Hide resolved
izadiegizabal
izadiegizabal approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@izadiegizabal izadiegizabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor improvements but nice work!

core/ui/src/main/kotlin/nl/q42/template/ui/theme/AppColorSchemeLight.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/AppTheme.kt Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/AppTheme.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/compose/composables/widgets/TemplateButton.kt Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/Colors.kt Outdated Show resolved Hide resolved
core/ui/src/main/kotlin/nl/q42/template/ui/theme/Dimens.kt Outdated Show resolved Hide resolved
feature/home/src/main/kotlin/nl/q42/template/home/main/ui/HomeContent.kt Outdated Show resolved Hide resolved
feature/home/src/main/kotlin/nl/q42/template/home/second/ui/HomeSecondScreen.kt Outdated Show resolved Hide resolved
ninovanhooff
ninovanhooff commented Jan 21, 2025
View reviewed changes
Copy link
Collaborator Author

@ninovanhooff ninovanhooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add edgeToEdge request

@ninovanhooff ninovanhooff merged commit e2cd9d8 into main Jan 24, 2025
5 checks passed
@ninovanhooff ninovanhooff deleted the custom-theming branch January 24, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izadiegizabal izadiegizabal izadiegizabal approved these changes

@Vluuks Vluuks Awaiting requested review from Vluuks

Assignees

@izadiegizabal izadiegizabal

@Vluuks Vluuks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ninovanhooff @izadiegizabal @Vluuks @Kr0sFyr3