Fix showing page tree items without slug #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstikvoort
reviewed
Jan 9, 2025
| @@ -110,7 +110,7 @@ export const PageTreeViewItem = ({ | |||
| onClick={onItemClick}> | |||
| <Flex align="center" gap={3}> | |||
| <UrlText isDisabled={isDisabled || (!page.isPublished && page.isDraft)} textOverflow="ellipsis"> | |||
| {parentPath ? page.slug?.current : getRootPageSlug(page, config) ?? '/'} | |||
| {parentPath ? page.slug?.current ?? 'untitled' : getRootPageSlug(page, config) ?? '/'} | |||
There was a problem hiding this comment.
I do not think that untitled is the right word here. Maybe fall back on title and otherwise untitled?
There was a problem hiding this comment.
We never show the title in the page tree but always the slug, right? I chose untitled, because sanity does the same for documents that do not have a title-like field available. I feel like that consistency is nice here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if any page was added to the page tree and the user did not add a title/slug the page is not shown in the tree. Once you close the editor it is hard to find again and results in unused draft pages.
This fix shows these pages as
untitledin the tree so that they can be updated or removed by users.