Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill template from backend #265

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

giangiac
Copy link
Contributor

@giangiac giangiac commented Jul 7, 2024

This is the second step of the 4-step plan:

  • merge Get alternative frontend back in the codebase #250 so that the frontend v2 [what we called the alternative frontend and should be the official frontend moving forward] returns to the main TQEC repo in folder <repo>/ggg_frontend
  • merge latest development to the frontend v2 [from Gian's fork]
  • create another PR to move frontend v1 to <repo>/old_frontend, and move frontend v2 to <repo>/frontend
  • find a way to update the tqec website

Specifically, what are the features added to the frontend v2?

  • add tab 4 in which one can fill templates using the plaquette from tab 2
  • interface between the JS frontend and a simple Python program acting as the backend
  • the frontend request data from the backend in the form of a JSON file containing a library of templates
  • the user can select the template to fill from a drop-down menu on top of tab 4
  • drag-and-drop one plaquette-type per cell with different label, then click on the "fill the template" button to complete the template

@giangiac
Copy link
Contributor Author

giangiac commented Jul 7, 2024

This is a relatively large PR, so I am not sure who would like to review it.
@afowler @Gistbatch @vtomole @nelimee

I will showcase the latest features in the next available TQEC meeting, perhaps this will attract interest from other possible reviewers.

@giangiac giangiac added frontend Issues pertaining to the React frontend needs-review labels Jul 7, 2024
@afowler
Copy link

afowler commented Jul 7, 2024 via email

@Gistbatch
Copy link
Contributor

I can have a look later this week

@giangiac
Copy link
Contributor Author

I can have a look later this week

That would be great!

After the review, I think we should merge the new features and complete the 3rd step of the plan before further developing the frontend.

@nelimee
Copy link
Contributor

nelimee commented Jul 25, 2024

@giangiac I can accept that to avoid you being blocked, but I cannot really review that as I am not at all in the frontend part. If you think it is acceptable to merge it as-is, and because:

  • you are the only one working on that currently and,
  • reviews from others seem to really slow down the development pace,

I can do a fake review, accepting the changes, but without actually looking at what you wrote. Just tell me.

@nelimee
Copy link
Contributor

nelimee commented Oct 9, 2024

The checks that are still failing are "expected" in the sense that you developed on your own branch, which does not have all the permissions needed to run all the CI jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues pertaining to the React frontend needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants