-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill template from backend #265
base: main
Are you sure you want to change the base?
Conversation
This is a relatively large PR, so I am not sure who would like to review it. I will showcase the latest features in the next available TQEC meeting, perhaps this will attract interest from other possible reviewers. |
Look forward to the demo on Wednesday, there is always time to demo
progress :-)
Best,
Austin.
…On Sun, Jul 7, 2024, 8:10 AM giangiac ***@***.***> wrote:
This is a relatively large PR, so I am not sure who would like to review
it.
@afowler <https://github.com/afowler> @Gistbatch
<https://github.com/Gistbatch> @vtomole <https://github.com/vtomole>
@nelimee <https://github.com/nelimee>
I will showcase the latest features in the next available TQEC meeting,
perhaps this will attract interest from other possible reviewers.
—
Reply to this email directly, view it on GitHub
<#265 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAXTDA7QUT3SBL4CX6MHTZLFLADAVCNFSM6AAAAABKPNYVGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGQ4DCMJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I can have a look later this week |
The message relates to the filled template in tab 4
That would be great! After the review, I think we should merge the new features and complete the 3rd step of the plan before further developing the frontend. |
@giangiac I can accept that to avoid you being blocked, but I cannot really review that as I am not at all in the frontend part. If you think it is acceptable to merge it as-is, and because:
I can do a fake review, accepting the changes, but without actually looking at what you wrote. Just tell me. |
The checks that are still failing are "expected" in the sense that you developed on your own branch, which does not have all the permissions needed to run all the CI jobs. |
This is the second step of the 4-step plan:
<repo>/ggg_frontend
<repo>/old_frontend
, and move frontend v2 to<repo>/frontend
Specifically, what are the features added to the frontend v2?