Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, peaceiris/actions-mdbook@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Book tests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Book tests

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Book tests

Rustfmt

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rustfmt

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L232

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:232:14 | 232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L226

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:226:14 | 226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/note_encryption_v3.rs#L343

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption_v3.rs:343:18 | 343 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/1633e2ae0630d21e668ce0a17f6268dfedf6becd/library/core/src/iter/traits/iterator.rs:643:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

use of `default` to create a unit struct: src/note/commitment.rs#L164

warning: use of `default` to create a unit struct --> src/note/commitment.rs:164:31 | 164 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

use of a fallible conversion when an infallible one could be used: src/keys.rs#L330

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:330:27 | 330 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ help: use: `into()` | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

use of a fallible conversion when an infallible one could be used: src/keys.rs#L269

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:269:27 | 269 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ help: use: `into()` | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default

accessing first element with `notes.get(0)`: tests/zsa.rs#L167

warning: accessing first element with `notes.get(0)` --> tests/zsa.rs:167:17 | 167 | let note1 = notes.get(0).unwrap(); | ^^^^^^^^^^^^ help: try: `notes.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L232

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L226

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/note_encryption_v3.rs#L343

use of a fallible conversion when an infallible one could be used: src/keys.rs#L330

use of a fallible conversion when an infallible one could be used: src/keys.rs#L269

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L532

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:532:14 | 532 | .fold(Some(ValueSum::zero()), |acc, action| { | ______________^ 533 | | acc? + action.value_sum() 534 | | }) | |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L455

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:455:14 | 455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L532

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L455

unused imports: `H`, `ValueCommitV`: src/constants.rs#L6

warning: unused imports: `H`, `ValueCommitV` --> src/constants.rs:6:77 | 6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H}; | ^^^^^^^^^^^^ ^ | = note: `#[warn(unused_imports)]` on by default

unused imports: `H`, `ValueCommitV`: src/constants.rs#L6