Skip to content

Dcmqi install step improvements #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Conversation

lorteddie
Copy link

No description provided.

@fedorov
Copy link
Member

fedorov commented Mar 12, 2021

@akalali FYI - in case you want to check this in the context of #429

@fedorov
Copy link
Member

fedorov commented Mar 12, 2021

@lorteddie are you still working on this, or it is ready to merge?

@lorteddie lorteddie force-pushed the dcmqi-install-step-2 branch 2 times, most recently from 6100280 to d6085c9 Compare March 13, 2021 19:16
@lorteddie
Copy link
Author

ready from my side, unfortunately i didn't test the last cmake change after removing the build directory, this change fixes paths in the cmake files pointing into the build directory
i also removed the zlib include since i don't understand why it is there (and it fails with dcmtk built with zlib). and since the dcmtk cmake config file still uses library and include paths instead of targets, their dependencies like zlib aren't covered by DCMTK_INCLUDE_DIRS

@fedorov
Copy link
Member

fedorov commented Mar 14, 2021

I will merge, but will see how this plays with the Slicer superbuild.

@fedorov fedorov merged commit ac7d0fe into QIICR:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants