forked from anthcourtney/ansible-role-cis-amazon-linux
-
Notifications
You must be signed in to change notification settings - Fork 27
Pre flight check fail on cis_target_os_versions and privileged binaries list not populating (#76) #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yobooooi
wants to merge
64
commits into
QLPD:master
Choose a base branch
from
yobooooi:Rule-4.1.12-FIX
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d9d825.
removing apt upgrade as it is causing Travis build issues
Travis updates and removing always_run
Multiple changes
…sctl-paths 3.3.1-2 Trigger flush on IPv6 sysctl path after modifying IPv6 routing
…zon-linux into build
Fix issues 45, 48 and more testing related changes
Testing and cosmetic changes
…of-non-disk-mounts Gather facts of non-disk mounts for tasks 1.1.15, 1.1.16, 1.1.17
Fix incorrect section and rule tags
cosmetic changes - remove trailing empty lines
Cosmetic changes to follow ansible formatting
Item 6.2.6 has to check PATH, which is apparently not set when using `script` module. Running `bash -l` from the `command` module allows to set the environment, but requires to copy the script to the remote machine. Cleanup included.
Fix missing environment in 6.2.6
changes for v1.1.8
pulling in changes from fork
Adding check on existing ntp options
Adding version 2018.03
Update main.yml
…e_distribution_version
…s to ensure list is populated so it can be stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
new PR for the Pre flight check fail on cis_target_os_versions and privileged binaries list not populating (anthcourtney#76)
I pulled the build branch and merged my changes and fixed the merge conflicts. I created a new PR with the changes with respect to the previous PR. Let me know if there's still issues. Not sure if i followed the correct work flow
anthcourtney#76