Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e testing check auth guard #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doanthai
Copy link

@doanthai doanthai commented Nov 2, 2024

Just for test. Please don't merge this request. I must ignore all hashing password code because you ignore them.

@doanthai
Copy link
Author

doanthai commented Nov 2, 2024

@anthonyyoussef01 You can pull and run this code for this issue: Stackoverflow

@anthonyyoussef01
Copy link
Member

Thank you, taking a look now, I don't have the password hashing method published as I am not sure if it's a privacy concern for user passwords. What do you think?

@doanthai
Copy link
Author

doanthai commented Nov 3, 2024

I thinks just need secure secret key for hashing and use salt is enough. But if you have more problems with passport, you should consider use open source identity and access management (IAM) solution such as: Keycloak, Auth0, Shibboleth. Although IAM solution is more large than only password, but it support every for authentication, authorization and integration with them isn't too hard.
Other simple way, just use jwt and session for store token, see more here
One more thing, I heart from some topics that passport.js is poor support with less detail document and just has some developer resolve ~300 issue on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants