Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution 2: Fix undefined variables #2514

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

azamat-bakytzhan
Copy link

@azamat-bakytzhan azamat-bakytzhan commented Dec 20, 2024

This MR restructures/reformats the documentation so that only code blocks are used for code snippets.

In addition, I have added 2 fixes for both branches:

  1. Changed validation to validation_data
  2. Added print(job.result()) in the Get Started section to wait for the job to finish before printing print(client.files()).

closes #2297

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@azamat-bakytzhan azamat-bakytzhan changed the title Solution 1: Fix undefined variables Solution 2: Fix undefined variables Dec 20, 2024
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

This looks great, I'll try and run the notebook using our framework ASAP to double-check it works correctly with our tokens etc. In the meantime, I just have a couple of comments about output length.

docs/guides/multiverse-computing-singularity.ipynb Outdated Show resolved Hide resolved
docs/guides/multiverse-computing-singularity.ipynb Outdated Show resolved Hide resolved
@frankharkins
Copy link
Member

@azamat-bakytzhan thanks! One last thing, I'm trying to run this notebook locally and I'm getting the following error from singularity.run.

QiskitServerlessException: 
| Message: Http bad request.
| Code: 404

Have you experienced this? I assume it's not a problem with the notebook; could it be that I don't have access to the function? Or maybe serverless is down temporarily.

@azamat-bakytzhan
Copy link
Author

@azamat-bakytzhan thanks! One last thing, I'm trying to run this notebook locally and I'm getting the following error from singularity.run.

QiskitServerlessException: 
| Message: Http bad request.
| Code: 404

Have you experienced this? I assume it's not a problem with the notebook; could it be that I don't have access to the function? Or maybe serverless is down temporarily.

Can you try to authorize differently?

client = IBMServerlessClient(token="<your token>")
catalog = QiskitFunctionsCatalog(token="<your token>")

@frankharkins
Copy link
Member

Yeah same problem :/

I'll see if I can create a minimal reproduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

multiverse guide has undefined variables
5 participants