Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple unpacking bug fix in cut finder. (backport #591) #593

Merged
merged 1 commit into from
May 15, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 15, 2024

There was a tuple unpacking error that arose when theCutBothWires action was invoked as part of the rest of the cut finding workflow. This bug was not noticed at first because the although existing tests called that line, its output was not used in any part of the rest of the workflow. This bug was noticed in the work leading up to #586 which will also add more comprehensive tests for the CutBothWires action. The goal of this PR is just to fix this bug and edit the corresponding tests and type hints accordingly.


This is an automatic backport of pull request #591 done by Mergify.

* tuple unpacking bug fix, edit tests and type hints accordingly.

* remove extraneous type hint

(cherry picked from commit 9d789f7)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9100086713

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.468%

Totals Coverage Status
Change from base Build 9099676313: 0.0%
Covered Lines: 3497
Relevant Lines: 3663

💛 - Coveralls

@garrison garrison merged commit 0accd7a into stable/0.7 May 15, 2024
11 checks passed
@garrison garrison deleted the mergify/bp/stable/0.7/pr-591 branch May 15, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants