-
Notifications
You must be signed in to change notification settings - Fork 43
Store logs on free resources #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to store-logs-on-free-resources
Co-authored-by: avilches
|
After the meeting to review the PR, these are the agreed points:
In another PR:
|
ElePT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, I think that it would be good to also start documenting more internal-facing changes in the release notes, as we started doing with interface changes. I left some pointers in another PR on how to do this: #1788 (comment). If you don't agree, I am open for discussion on what should and shouldn't be part of the renos.
|
|
||
| if job_handler: | ||
| logs = job_handler.logs(job.ray_job_id) | ||
| job.logs = check_logs(logs, job) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch @korgan00 ! If we trim the logs, how can we will know later if the no_resources_log message is in the logs? :)
Summary
free_resourcescommand to be able to download de logs from Ray and store them into the COS.Getendpoints to get the logs from COS > Ray > Database and filter them for partners or users.Details and comments
Upload logs file from free_resources command
The idea is that, at the moment we cleanup the resources consumed by a Function we also upload to the COS the logs from the database. The place would be here.
Some things to take into account for the creation of these files:
GET end-points:
We will need to modify a bit the logic in these end-points. If the Job is in a final status we are going to return the content of each file:
If the Job is in another state we will return the logs from Ray directly and we will filter by [PUBLIC] in case the end-point would be /logs.