Merged
Conversation
ihincks
reviewed
Feb 21, 2026
| return table | ||
|
|
||
|
|
||
| C1_PAST_CLIFFORD_LOOKUP_TABLES = { |
Collaborator
There was a problem hiding this comment.
This will increase import time. I'd be curious to see a benchmark to see if we want to hardcode lookup tables.
Collaborator
Author
There was a problem hiding this comment.
I hardcoded the lookup tables, it was ~0.02s faster.
Comment on lines
+143
to
+145
| raise SamplexRuntimeError( | ||
| f"C1 values did not remain local after conjugation by {self._op_name!r}." | ||
| ) |
Collaborator
There was a problem hiding this comment.
We plan for build() to make this situation impossible, right?
Collaborator
Author
There was a problem hiding this comment.
Yeah this shouldn't happen. With the way it's setup in in #308 the this is possible to hit if you have a left dressed box with one entangler then a right dressed box with another entangler both with different local C1 twirling groups.
ihincks
reviewed
Feb 23, 2026
| from samplomatic.virtual_registers.c1_register import C1_TO_TABLEAU | ||
|
|
||
|
|
||
| class TestLookupTables: |
Collaborator
There was a problem hiding this comment.
can this please be moved to test/unit/tables?
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
ihincks
reviewed
Feb 23, 2026
ihincks
approved these changes
Feb 23, 2026
joshuasn
added a commit
that referenced
this pull request
Mar 6, 2026
## Summary Following #306 and #307, this PR adds local Clifford twirling. This can be enabled by setting the new `twirling_group` argument of the `generate_preset_pass_manager` or the `group` argument of the `Twirl` annotation to `local_c1`. ## Details and comments A lot of the building stage is forward looking to support RZZ twirling. As the two-qubit entanglers are Hermitian, there is a single local C1 subgroup. For non-Hermitian gates, we can do the same thing but would need different subgroups for left- and right-dressed boxes. I used Claude Ops 4.6. --------- Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
C1PastCliffordNode, required for local Clifford twirling. The node works similarly to thePauliPastCliffordNode, except that the lookup tables contain a sentinel-1where C1 x C1 are promoted to C2.Details and comments
I used Claude Opus 4.6.