This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
refactor(frontend): now with jotai and code split #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to refactor the front end shell with Jotai + React Query and start splitting the code in a cleaner way so it can be built on.
I also took the liberty to change the layout along with the card design.
The sidebar that used to hold the form is a now a dialog for cleaner UX.
The
runsAPI call is no longer suitable for what we want to achieve, it would require us to have an API that fetch all the runs for all the catalogs.Self service view
Create Service Dialog