Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to relax beartype on numpy type int #925

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

johnzl-777
Copy link
Collaborator

Users are currently encountering the following when calling .show or .counts on Report objects.

BeartypeCallHintReturnViolation: Method bloqade.task.base.Report.counts() return [OrderedDict([('1', 8148), ('0', 1852)]), OrderedDict([('1', 6098), ('0', 3902)]), Ordere...)])] violates type hint list[collections.OrderedDict[str, int]], as list index 6 item <protocol "collections.OrderedDict"> key str '0' value <protocol "numpy.int64"> 9449 not instance of int.

It seems all existing infrastructure works without this check present, I'm unsure of the origin of the problem (I suspect a dependency is doing something considering this was a non-problem before and the last release just modified the pydantic version, not beartype).

@johnzl-777 johnzl-777 merged commit b096df8 into main Apr 13, 2024
6 of 8 checks passed
@johnzl-777 johnzl-777 deleted the john/beartype-hotfix branch April 13, 2024 16:06
johnzl-777 added a commit that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant