-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unitary hack] Improve Docstrings task/quera.py #971
Conversation
Improve Docstrings, Remove Markdown Errors
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 89.90% 89.91%
=======================================
Files 110 110
Lines 8132 8128 -4
=======================================
- Hits 7311 7308 -3
+ Misses 821 820 -1 ☔ View full report in Codecov by Sentry. |
@Roger-luo please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just need to address the comments.
Co-authored-by: Phillip Weinberg <weinbe58@gmail.com>
@weinbe58 I have addressed the changes as requested by you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think like the other PR, we should have some examples demonstrating how to use these APIs instead of just plain explanations.
I'm going to comment on your other PRs with the same comment as following to avoid duplicated review comments for other reviewers: I think you should work on #975 first instead of asking people to review other PRs, so we don't resolve duplicated issues in multiple PRs. |
@Roger-luo I just addressed all the requirements @weinbe58 mentioned. I am working on other PRs where you have mentioned changes related to examples. |
Fixes #957
Improve Docstrings, Remove Markdown Errors