Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unitary-Hack][Sub-ir-braket] Doc in submission/ir/braket.py #978

Merged

Conversation

Manvi-Agrawal
Copy link
Contributor

@Manvi-Agrawal Manvi-Agrawal commented Jun 1, 2024

Fixes #984.

Related #957.

bloqade_sub_ir.pdf

@Manvi-Agrawal Manvi-Agrawal changed the title Doc [Unitary-Hack][Submission-ir-braket] Doc in submission/ir/braket.py Jun 1, 2024
@Manvi-Agrawal Manvi-Agrawal changed the title [Unitary-Hack][Submission-ir-braket] Doc in submission/ir/braket.py [Unitary-Hack][Sub-ir-braket] Doc in submission/ir/braket.py Jun 1, 2024
@Manvi-Agrawal
Copy link
Contributor Author

@Roger-luo , I think this might be a good next PR for you to review. This builds up on our discussion from previous PR and I have checked that there are no similar suggestions :-)

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While adding a docstring to helper functions is fine, I'm OK with accepting this PR as a bounty since it's already been made and we might not be clear on what methods you should be working on.

However, we will not accept docstrings added to helper functions or private methods in the future. Please work on public APIs in the user space, as I mentioned in #957. This means you should at least take a look at the quick start and tutorial to understand what this package does.

src/bloqade/submission/ir/braket.py Outdated Show resolved Hide resolved
src/bloqade/submission/ir/braket.py Outdated Show resolved Hide resolved
Co-authored-by: Xiu-zhe (Roger) Luo <hiroger@qq.com>
@Roger-luo Roger-luo mentioned this pull request Jun 3, 2024
3 tasks
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (9fdc8cb) to head (3bc413a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   89.90%   89.91%   +0.01%     
==========================================
  Files         110      110              
  Lines        8132     8132              
==========================================
+ Hits         7311     7312       +1     
+ Misses        821      820       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, as I commented above, I'll make an exception to count this as 10 docstrings = 40 USD bounty.

@Roger-luo Roger-luo merged commit bb8ab82 into QuEraComputing:main Jun 5, 2024
9 of 10 checks passed
@Manvi-Agrawal
Copy link
Contributor Author

I think this is good to go, as I commented above, I'll make an exception to count this as 10 docstrings = 40 USD bounty.

Thanks a ton @Roger-luo and @weinbe58 for support.

@Roger-luo Roger-luo linked an issue Jun 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unitaryhack tracking issue by Manvi-Agrawal [Unitary-Hack][Sub-ir-braket] Doc in submission/ir/braket.py
3 participants