-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unitary-Hack][Sub-ir-braket] Doc in submission/ir/braket.py #978
[Unitary-Hack][Sub-ir-braket] Doc in submission/ir/braket.py #978
Conversation
@Roger-luo , I think this might be a good next PR for you to review. This builds up on our discussion from previous PR and I have checked that there are no similar suggestions :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding a docstring to helper functions is fine, I'm OK with accepting this PR as a bounty since it's already been made and we might not be clear on what methods you should be working on.
However, we will not accept docstrings added to helper functions or private methods in the future. Please work on public APIs in the user space, as I mentioned in #957. This means you should at least take a look at the quick start and tutorial to understand what this package does.
Co-authored-by: Xiu-zhe (Roger) Luo <hiroger@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 110 110
Lines 8132 8132
==========================================
+ Hits 7311 7312 +1
+ Misses 821 820 -1 ☔ View full report in Codecov by Sentry. |
…-Agrawal/bloqade-python into manvi/submission-ir-braket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, as I commented above, I'll make an exception to count this as 10 docstrings = 40 USD bounty.
Thanks a ton @Roger-luo and @weinbe58 for support. |
Fixes #984.
Related #957.
bloqade_sub_ir.pdf